-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rfc formatting #25
Conversation
Very great! 👍 |
The standard is officially called In the section Assignment operators I would write |
6e10b3f
to
8dfa6de
Compare
@retokromer I'm following the practice for referencing ISO/IEC standards as done at https://xml2rfc.tools.ietf.org/public/rfc/bibxml2/. In the cases here ISO/IEC standards use anchors that are prefixed with only |
The change for QuantizationTablePerContext adds some \ |
the indention of the elements in the 2nd column is inconsistet, for example the br element between the Frame and SliceHeader |
in SliceHeader() you randomize the indention, sar_den and the following if() are at the same indentio level before a02463a and 1 space different after. |
@michaelni I couldn't see the character you meant in #25 (comment). But I found an extra |
Indentation noted in #25 (comment) and #25 (comment) is fixed in fbe46cc. |
1624636
to
fbe46cc
Compare
I think I've updated according to all comments. Please re-review. I can also squash the codeblock commits together if easier. |
Comment 25 was about a backslash |
8733905
to
0153199
Compare
Commits are squashed to eliminate introducing/fixing bugs and for readability. |
Thanks |
0153199
to
53d2b04
Compare
@dericed It´s not the link itself, but the wording I see that hurts me: the title reads wrong in markdown this way. |
I updated the Parameters indentation. For the rest which exists prior, let's leave for a later PR. |
@retokromer can you move the question on iso citation style to cellar. |
The change to SliceContent() is not correct, same for Line(), the indention in Parameters() also is still not correct |
53d2b04
to
7980a8f
Compare
I reviewed codeblocks for indentation and order. PR is updated. |
Pixel() is wrongly indented after te first patch in Line() |
e744082
to
b17691d
Compare
I fixed |
a4be5c0
to
09a576d
Compare
And rebased to remove the commit on resolving merge conflicts. Should be ready. |
09a576d
to
2abe15d
Compare
merged 1 patch, Is it intended that the "left-align" patch skips the Suffix Examples table ? |
2abe15d
to
b5a98d1
Compare
Updated to left-align the Suffix Examples table. |
@retokromer, regarding #25 (comment), I agree but didn't want to extend the scope of the PR, so I filed it under #27 |
@michaelni, anything else needed for the remaining commits? |
4504e25 make the table rather hard to read in the pdf. The individual terms are hard to see in the flowing text that reaches into the same first column |
e1becfb
to
ede0d75
Compare
Is it intended that a130bbc causes litteral "@!" to be shown in the the output (pdf in this case) ? |
The "@!" is part of mmark's syntax to identify a reference in the RFC output, though this shows as a literal in the PDF output. I suppose we could add a 'sed s/[@!/[/g' to the Makefile before the PDF output is rendered. ? |
On Wed, Dec 14, 2016 at 05:34:26AM -0800, Dave Rice wrote:
The "@!" is part of mmark's syntax to identify a reference in the RFC output, though this shows as a literal in the PDF output. I suppose we could add a 'sed s/[@!/[/g' to the Makefile before the PDF output is rendered. ?
if theres no cleaner solution then that seems like a good idea
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have often repented speaking, but never of holding my tongue.
-- Xenocrates
|
+1 for filtering out mmark’s own syntax before rendering the PDF. |
ede0d75
to
e8f9b21
Compare
@michaelni please confirm that the reference to jpeg2000.org can be swapped to ISO.15444-1.2016. Preferable to reference a standard rather than a website. The jpegls ref is updated to iso14495. The fcd14495p.pdf url was dead anyhow.
compromise between rfc and pandoc outputs
e8f9b21
to
ccd33f2
Compare
The solution suggested in #25 (comment) is implemented in ccd33f2#diff-b67911656ef5d18c4ae36cb6741b7965R15. I also dropped a few commits from the PR that were already cherrypicked. |
LGTM |
ccd33f2
to
8964520
Compare
merged |
This pull request updates many aspects of the formatting for better handling when transformed through rfc2xml. For instance see the visual issues with https://tools.ietf.org/html/draft-niedermayer-cellar-ffv1-00#section-5.2.
This PR is not intended to produce any semantic change, except for some minor changes in referencing.
@michaelni please confirm that the reference to jpeg2000.org can be
swapped to ISO.15444-1.2016. Preferable to reference a standard rather
than a website.
The jpegls ref is updated to iso14495. The fcd14495p.pdf url was dead anyhow.